feat(pipenv): Use centralized docker execution #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
force-pushed
the
refactor/pipenv-docker
branch
from
9ef77d5
to
0e98e8c
Compare
viceice
previously approved these changes
Jan 7, 2020
viceice
reviewed
Jan 7, 2020
lib/manager/pipenv/artifacts.ts
Outdated
| tag: null, | ||
| dockerUser: config.dockerUser, | ||
| volumes: [config.localDir, process.env.PIPENV_CACHE_DIR], | ||
| envVars: ['LC_ALL', 'LANG', 'PIPENV_CACHE_DIR'], |
There was a problem hiding this comment.
@rarkins Shouldn't those env vars always passed to child process? 🤔
zharinov
changed the title
zharinov
changed the title
zharinov
force-pushed
the
refactor/pipenv-docker
branch
from
8796d0d
to
3c7a45c
Compare
zharinov
changed the title
rarkins
requested changes
Jan 27, 2020
added 2 commits
January 29, 2020 09:23
rarkins
changed the title
# Conflicts: # lib/manager/pipenv/artifacts.spec.ts
rarkins
approved these changes
Feb 9, 2020
|
🎉 This PR is included in version 19.127.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2863