fix(exec): Whitelist LC_ALL and LANG

[zharinov]

Ref #5062

[zharinov]

https://docs.docker.com/network/proxy/

[rarkins]

Can you explain this more? We need to pass env vars to child process but not to Docker itself via -e

[zharinov]

I thought, pipenv pass them to Docker already and we should do for all. Well, here we have two options: (1) extend basic vars with LANG and LC_ALL, passing it to Docker explicitly when needed or (2) pass it always as done in this PR.

[rarkins]

Thanks, I understand better. I wonder if they’re only needed for child process when using global binary source. In which case, they should be safe to include on the default whitelist. If they’re needed inside the container then we should build them into the container if not already

[zharinov]

By the way, I doubt LC_ALL and LANG actually needed for pipenv. This is the only place we pass basic vars into container.

[rarkins]

By the way, I doubt LC_ALL and LANG actually needed for pipenv. This is the only place we pass basic vars into container.

I suspect there were only needed for binarySource=global. Let's add them to our whitelisted env vars for child process and not pass them into the container itself.

[renovate-release]

🎉 This PR is included in version 19.112.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀