Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gradle):infer gradle-wrapper url from distributionUrl #5786

Merged
merged 3 commits into from
Mar 26, 2020
Merged

feat(gradle):infer gradle-wrapper url from distributionUrl #5786

merged 3 commits into from
Mar 26, 2020

Conversation

driver733
Copy link
Contributor

Closes # #4807

Now gradle-wrapper url is now inferred from the distributionUrl from the gradle-wrapper.properties.

@driver733 driver733 changed the title feature(gradle):infer gradle-wrapper url from distributionUrl feat(gradle):infer gradle-wrapper url from distributionUrl Mar 26, 2020
@driver733 driver733 force-pushed the gradle-wrapper-infer-url branch 2 times, most recently from 09a572e to 0db494d Compare March 26, 2020 11:37
@viceice viceice self-requested a review March 26, 2020 11:42
viceice
viceice requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test fixes

@lgtm-com
Copy link

lgtm-com bot commented Mar 26, 2020

This pull request introduces 1 alert when merging 6e71a7f into bc98241 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@driver733
feat(gradle): gradle-wrapper url is now inferred from the distributio…
851ec13 
…nUrl from the gradle-wrapper.properties

Signed-off-by: Mikhail Yakushin <driver733@gmail.com>
@driver733
Copy link
Contributor Author

@viceice The tests are fixed.

@driver733 driver733 requested a review from viceice March 26, 2020 14:44
viceice
viceice approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driver733
Copy link
Contributor Author

@viceice It seems that there are some issues with the Docker Registry login in the release pipeline. Can you check?

@viceice
Copy link
Member

viceice commented Mar 26, 2020

I know, sorry. will be fixed by #5788

@driver733
Copy link
Contributor Author

@viceice Thanks for the fix!
The PR has passed all checks. Can you merge it?

@viceice viceice merged commit 512abc0 into renovatebot:master Mar 26, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.182.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@driver733 driver733 deleted the gradle-wrapper-infer-url branch March 26, 2020 18:57
@ikesyo ikesyo mentioned this pull request Mar 27, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@driver733 @viceice @renovate-release