Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose.extractPackageFile silently assumes version 2+ #6570

Closed
wolfgang42 opened this issue Jun 23, 2020 · 1 comment · Fixed by #6596
Closed

docker-compose.extractPackageFile silently assumes version 2+ #6570

wolfgang42 opened this issue Jun 23, 2020 · 1 comment · Fixed by #6596
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:docker-compose Docker Compose files priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@wolfgang42
Copy link
Contributor

What Renovate type are you using?
Self-hosted.

Describe the bug
Renovate assumes that a docker-compose.yaml file will have a services key, which is only true of version 2 and 3 docker-compose files; version 1 puts all of the services on the top level. This causes renovate to silently fail to find anything to update on older compose files.

Ideally Renovate should check the version and load the services from the root if it's absent, or at least log a message explaining that this is what happened.

To Reproduce
Run renovate on a docker-compose v1 file and then spend several hours trying to figure out what you've misconfigured to make it not try to update anything.
@viceice viceice added type:bug Bug fix of existing functionality manager:docker-compose Docker Compose files priority-2-high Bugs impacting wide number of users or very important features labels Jun 23, 2020
@rarkins rarkins added the auto:reproduction A minimal reproduction is necessary to proceed label Jun 23, 2020
wolfgang42 added a commit to wolfgang42/renovate that referenced this issue Jun 27, 2020
@wolfgang42
fix(docker-compose): support docker-compose.yml version 1
a160423 
Closes renovatebot#6570.
@wolfgang42 wolfgang42 mentioned this issue Jun 27, 2020
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:docker-compose Docker Compose files priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docker-compose): support docker-compose.yml version 1 wolfgang42/renovate
4 participants
@viceice @wolfgang42 @rarkins @renovate-release