Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Issue recreates itself #6571

Closed
Preisschild opened this issue Jun 24, 2020 · 5 comments · Fixed by #6597
Closed

Master Issue recreates itself #6571

Preisschild opened this issue Jun 24, 2020 · 5 comments · Fixed by #6597
Labels
platform:gitlab GitLab Platform priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@Preisschild
Copy link

Preisschild commented Jun 24, 2020

What Renovate type are you using?
Platform: Gitlab
Renovate: Selfhosted Docker Container 21.12.4

Describe the bug
On Gitlab, renovate seems to ignore the existing master issue every few days and creates a new one (without closing or doing anything else with the existing one).

Did you see anything helpful in debug logs?

To Reproduce

Additional context

I think the issue could be a paging issue.

It seems like Renovate creates a new issue every time the existing master issue is not on the first page anymore.

@rarkins
Copy link
Collaborator

rarkins commented Jun 24, 2020

Need to check our getIssues() function for GitLab retrieves enough items.

Are you reusing the same account for Renovate plus anything else? Or does Renovate have a dedicated user account?

@Preisschild
Copy link
Author

Renovate has a dedicated user account.

@k-yle
Copy link
Contributor

k-yle commented Jun 26, 2020

We've been having this issue on gitlab too, it seems to occur after a significant number of issues have just been created.

@rarkins
Copy link
Collaborator

rarkins commented Jun 27, 2020

Here's the code:

export async function getIssueList(): Promise<any[]> {
if (!config.issueList) {
const res = await gitlabApi.getJson<{ iid: number; title: string }[]>(
`projects/${config.repository}/issues?state=opened`,
{
useCache: false,
}
);
// istanbul ignore if
if (!is.array(res.body)) {
logger.warn({ responseBody: res.body }, 'Could not retrieve issue list');
return [];
}
config.issueList = res.body.map((i) => ({
iid: i.iid,
title: i.title,
}));
}
return config.issueList;
}

We should set the per_page and author params like we do with PRs:

const query = new URLSearchParams({
per_page: '100',
author_id: `${authorId}`,
}).toString();

@rarkins rarkins added platform:gitlab GitLab Platform type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features labels Jun 27, 2020
rarkins added a commit that referenced this issue Jun 27, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.18.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:gitlab GitLab Platform priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants