-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseBranches
, but only when they exist
#6669
Comments
Actually, I have been recently considering making |
I don't understand what you mean here, sorry. BTW the choice to make the default branch re-specified was in order to give people the flexibility to not run Renovate on the default branch, which a few needed. |
this part gives me pause as well. maybe the default behavior could remain the same, but an additional flag could allow opting into the only-when-exists behavior?
no worries. let me try to explain better. since i'm hoping to configure this in a base config, i may extend in projects that are inconsistent in how the default branch is named. many are so, i was just wondering if you've considered or already enabled a way to say "include the default branch, whatever it happens to be" rather than directly specifying the strings if this doesn't already exist, i could see something along the lines of
this makes sense, and i think that its a good solution. i'm just wondering if there is a more dynamic way of re-specifying that it should be included than to hard-code the default branch name that could change over time (and get out of sync when configured in multiple places) or be inconsistent across projects when inheriting from a base config |
Transferring into the main repo. So there's two ideas:
|
In case it would be valuable to match the default branch token available now for actions: https://github.blog/changelog/2020-07-22-github-actions-better-support-for-alternative-default-branch-names/ |
Proposed solution: No longer error and abort if baseBranches are missing, instead WARN and continue with any other baseBranches that do exist |
Log a warning when baseBranches are missing but otherwise just skip over and keep going. Closes #6669
Log a warning when baseBranches are missing but otherwise just skip over and keep going. Closes #6669
🎉 This issue has been resolved in version 22.19.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
since it looks like renovatebot/renovate#6669 isnt rolled out quite yet
thanks so much for working through this one! i'm excited to try it out. so excited that it looks like i was premature in adjusting my config and started seeing issues opened, like form8ion/mocha-scaffolder#75. could you share what the timing of roll-out will look like? |
I'm pretty sure it's live now. Can you try again? |
sure thing. i reintegrated with form8ion/renovate-config@93cdd49 and haven't seen any new issues opened. looking forward to seeing the new branches get PRs soon. thanks again! |
Just to double check, you don't have any of those branches yet, right? https://github.com/form8ion/renovate-config/branches I also see that form8ion/mocha-scaffolder#75 was automatically closed, so that's a good sign |
i'm not actively working any of them right now. i certainly do not have them in all repos, but i may have a few
yep, along with several others after i pushed the shared config. those closed because of me reverting my change to enable the new branches. i re-reverted to re-enable in the commit above and no new issues have been opened. |
for a quick update, i've been seeing activity on branches that i havent gotten merged (i have more than usual right now for unrelated reasons) to add the branch name to the PR title (I like it 😄). i did have one pin-dependencies PR opened for a looking good so far |
and now an update PR for an existing |
Great, thanks for the feedback! |
Which Renovate are you using?
WhiteSource Renovate App
Which platform are you using?
GitHub.com
Have you checked the logs? Don't forget to include them if relevant
i think this is working as currently intended, and i appreciate the warning issues to encourage fixing config problems early.
What would you like to do?
I'm a heavy user of
semantic-release
. one of the things that it has greatly improved in my workflow is making pre-releases very easy. by default,semantic-release
will publish toalpha
andbeta
release channels for changes pushed toalpha
andbeta
branches, respectively. while i do try to keep these pre-release branches short-lived, there are times that i will consume a pre-release in a pre-release of another package. i would especially like pre-releases of the dependency that i'm working on to be PR'ed into the pre-release branch of the consumer, but would also find value in PRs for other updated dependencies that happen while the pre-release branch exists.After finding the baseBranches config option, i thought this would accomplish what i wanted. I added this to my base config for js-packages, but was quickly informed that i made some incorrect assumptions. I assumed that it would only apply if the branch existed, but it makes sense why it could be seen as incorrect config when the branch does now exist.
Is it currently possible to configure baseBranches, or something similar, in a way that only applies when the branch exists? Also, since the default branch needs to be re-specified, is there a way to more directly use the configured for the repository in question (especially important if specifying this in my base config that applies across many projects that could be in various stages of transitioning away from using
master
as the default branch)?The text was updated successfully, but these errors were encountered: