Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git-submodule): disable pinDigests #6754

Merged
merged 1 commit into from Jul 14, 2020
Merged

fix(git-submodule): disable pinDigests #6754

merged 1 commit into from Jul 14, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 14, 2020

closes: #6753

@viceice viceice requested a review from rarkins July 14, 2020 14:10
@viceice
Copy link
Member Author

viceice commented Jul 14, 2020

@rarkins Are I'm right that this will set pinDigest to false, even when it is set globally to true by a preset?

@rarkins
Copy link
Collaborator

rarkins commented Jul 14, 2020

Yes if it's configured at top level by the user then this will still override

@viceice viceice merged commit 467994b into master Jul 14, 2020
@viceice viceice deleted the fix/git-digest branch July 14, 2020 14:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.29.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-submodules manager doesn't work if config has pinning turned on
3 participants
@viceice @rarkins @renovate-release