Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .github repo to check for org-wide repo #7422

Closed
ljharb opened this issue Oct 7, 2020 · 5 comments · Fixed by #7423
Closed

Add .github repo to check for org-wide repo #7422

ljharb opened this issue Oct 7, 2020 · 5 comments · Fixed by #7423
Assignees
@rarkins
Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)

Comments

@ljharb
Copy link

ljharb commented Oct 7, 2020

Per renovatebot/config-help#816 (comment), the proper place for org-wide or user-wide github config is a .github repo - perhaps a renovate.json file in that repo?
@viceice
Copy link
Member

viceice commented Oct 7, 2020

This is only true for github, not for our other platforms like gitlab, azure, gitea, ...

How it should work there? We want to have a unique behavior for all platforms.

@ljharb
Copy link
Author

ljharb commented Oct 7, 2020

It seems like you have an existing behavior for all platforms; I'm suggesting that you should always prefer the idiomatic behavior for each platform, rather than the lowest common denominator. On github, that's a .github repo, full stop.

@rarkins
Copy link
Collaborator

rarkins commented Oct 7, 2020

I think it should be OK to check for .${platform} even if it's not convention for all others to have that yet.

@rarkins rarkins transferred this issue from renovatebot/config-help Oct 7, 2020
@rarkins rarkins changed the title org-wide config should come from .github repo Add .github repo to check for org-wide repo Oct 7, 2020
@rarkins rarkins added type:feature Feature (new functionality) priority-2-high Bugs impacting wide number of users or very important features labels Oct 7, 2020
@rarkins rarkins self-assigned this Oct 7, 2020
@rarkins
Copy link
Collaborator

rarkins commented Oct 7, 2020

I'll add this now, assuming it doesn't turn out to be much work

rarkins added a commit that referenced this issue Oct 7, 2020
@rarkins
feat: check for dot platform org preset when onboarding
82cdf26 
Checks for a renovate.json file in a repo like org/.github and uses it during onboarding if found.

Closes #7422
@rarkins rarkins mentioned this issue Oct 7, 2020
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 23.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ljharb ljharb mentioned this issue Oct 8, 2020
Closed
@viceice viceice mentioned this issue Oct 12, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check for dot platform org preset when onboarding renovatebot/renovate
4 participants
@ljharb @viceice @rarkins @renovate-release