Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for dot platform org preset when onboarding #7423

Merged
merged 5 commits into from Oct 8, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 7, 2020

Checks for a renovate.json file in a repo like org/.github and uses it during onboarding if found.

Closes #7422

Checks for a renovate.json file in a repo like org/.github and uses it during onboarding if found.

Closes #7422
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 7, 2020

@viceice @ljharb there's maybe one or two downsides to this. The ".github" repo itself then must use the same renovate.json for its own config and hence can't modify it or else all other repos will get the modifications passed on.

A second problem is maybe someone already has a .github repo and want to renovate it and so has a renovate.json already and it's not suitable for extending to all onboarding repos?

These are probably not problems in the majority of cases, but another alternative would be to use a different file name like renovate-config.json or renovate-org-config.json instead.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I suggest to use an other filename like renovate-config.json. otherwise LGTM

@rarkins rarkins marked this pull request as ready for review October 7, 2020 10:18
@ljharb
Copy link

ljharb commented Oct 7, 2020

Agreed; another filename makes sense.

Also, .github repos typically allow files either in the root, or in the .github repo's .github directory.

@rarkins rarkins merged commit 11172e4 into master Oct 8, 2020
@rarkins rarkins deleted the feat/7422-dot-platform-org-preset branch October 8, 2020 11:04
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ljharb added a commit to ljharb/.github that referenced this pull request Oct 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .github repo to check for org-wide repo
4 participants