feat: support node v14

[viceice]

• build v14 on ci
• fix ::set-env deprecation
• do not support node v13 (ended on 2020-06-01)

should we be more strict, eg ^12.13.0 || >=14.15.0 , as 14.15.0 is first v14 lts ?

[CLAassistant]

All committers have signed the CLA.

[rarkins]

should we be more strict, eg ^12.13.0 || >=14.15.0 , as 14.15.0 is first v14 lts ?

I think so, because we sometimes depend on features which are added to the major releases prior to LTS, and we have no interest in chasing after pre-LTS versions to work out why something's failing.

[viceice]

should we skip v12 or v14 tests on windows? as we've done with v10 before?

[JamieMagee]

Does this require a major version bump?

[viceice]

Does this require a major version bump?

Why? because we do not support node v13 anymore?

[viceice]

i can split this pr, so we first enable testing v14 only and later change the package.json node requirementes with a major bump, maybe dropping node support <14.15.0

[JamieMagee]

Yeah, it's technically breaking. Though now that I think about it, we drop unsupported versions of GHE without making a major release. This probably falls in the same category.

[rarkins]

I don't see why it's a major for us to add v14 support, although if we're taking anything away and it's deserving of a major then we could wait and combine it with others if it's not too inconvenient.

[viceice]

Yeah, it's technically breaking. Though now that I think about it, we drop unsupported versions of GHE without making a major release. This probably falls in the same category.

so yes, i think it's ok to drop unsupported versions with a minor update

I don't see why it's a major for us to add v14 support, although if we're taking anything away and it's deserving of a major then we could wait and combine it with others if it's not too inconvenient.

It's not because adding v14 support, it's because we explicit disallow node ^13 || <14.15

[renovate-release]

🎉 This PR is included in version 23.65.0 🎉

The release is available on:

• GitHub release
• 23.65.0

Your semantic-release bot 📦🚀