Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom filenames #799

Closed
rarkins opened this issue Sep 14, 2017 · 2 comments · Fixed by #1894
Closed

Support custom filenames #799

rarkins opened this issue Sep 14, 2017 · 2 comments · Fixed by #1894
Assignees
@rarkins
Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 14, 2017 •
edited

Move each package manager's filePattern into config/definitions.js so that users can override it by adding a custom file name. We should probably also add a "fail safe" to limit the number of package files resolved so we don't accidentally or deliberately end up with thousands of concurrent getFile requests.
@rarkins rarkins added blocked type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed blocked labels Sep 14, 2017
@rarkins rarkins added the manager:dockerfile Dockerfile files label Oct 13, 2017
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels Mar 5, 2018
@rarkins rarkins self-assigned this Mar 5, 2018
@rarkins rarkins changed the title Support custom Dockerfile filenames Support custom filenames Mar 5, 2018
@rarkins rarkins mentioned this issue Mar 5, 2018
Closed
@rarkins
Copy link
Collaborator Author

rarkins commented Apr 29, 2018

Make filePatterns a mergeable array instead of a single string. That way the user can add to the existing filePatterns without having to copy/paste them. Users wanting to restrict the existing pattern should either (a) use ignorePaths or (b) submit an issue pointing out that our default filePattern has a problem.

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:dockerfile Dockerfile files labels Apr 29, 2018
@rarkins rarkins mentioned this issue Apr 30, 2018
Merged
rarkins added a commit that referenced this issue Apr 30, 2018
@rarkins
feat: custom filenames for package files (#1894)
c356bb0 
Renovate now comes with a variety of package managers supported, each with their own filename pattern(s). These patterns are now exposed for user configuration through the new `fileMatch` list/array configuration option, which has been added to each manager (npm, bazel, docker-compose, etc). `fileMatch` is defined as a mergeable list, meaning that users can add to the default pattern to extend the files being detected.

Closes #799
@rarkins rarkins removed the ready label Apr 30, 2018
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 12.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: custom filenames for package files renovatebot/renovate
2 participants
@rarkins @renovate-bot