Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defect dependency dashboard when branch contains double dash #8260

Closed
1 of 5 tasks
viceice opened this issue Jan 12, 2021 · 1 comment · Fixed by #11186
Closed
1 of 5 tasks

Defect dependency dashboard when branch contains double dash #8260

viceice opened this issue Jan 12, 2021 · 1 comment · Fixed by #11186
Labels
core:dashboard Related to Dependency Dashboard functionality good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@viceice
Copy link
Member

viceice commented Jan 12, 2021

What Renovate type, platform and version are you using?
Any which supports dependency dashboard

Describe the bug
image

When a renovate branch contains a double dash -- the renovate html comment is broken

Relevant debug logs

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context

Can be reproduced with pre-commit manager:

.pre-commit-config.yam

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
  rev: v3.3.0
@viceice viceice added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jan 12, 2021
@viceice viceice changed the title Defect dependency dashboard when branch contains doupble dash Defect dependency dashboard when branch contains double dash May 26, 2021
@rarkins rarkins added the core:dashboard Related to Dependency Dashboard functionality label Jun 7, 2021
@rarkins rarkins added the good first issue Suitable for new contributors label Jul 26, 2021
@stroncium stroncium mentioned this issue Aug 9, 2021
Merged
6 tasks
rarkins pushed a commit that referenced this issue Aug 13, 2021
@stroncium
fix: remove double hyphens from branch names (#11186)
852cc3e 
Removes double or more hyphens from branch names and replaces with a single hyphen.

Closes #8260

BREAKING CHANGE: Branches with double hyphens will be changed to single hyphens, which can result in some existing PRs being autoclosed and replacements opened.
rarkins pushed a commit that referenced this issue Aug 15, 2021
@stroncium @rarkins
fix: remove double hyphens from branch names (#11186)
ebb5eb8 
Removes double or more hyphens from branch names and replaces with a single hyphen.

Closes #8260

BREAKING CHANGE: Branches with double hyphens will be changed to single hyphens, which can result in some existing PRs being autoclosed and replacements opened.
rarkins pushed a commit that referenced this issue Aug 16, 2021
@stroncium @rarkins
fix: remove double hyphens from branch names (#11186)
66524c6 
Removes double or more hyphens from branch names and replaces with a single hyphen.

Closes #8260

BREAKING CHANGE: Branches with double hyphens will be changed to single hyphens, which can result in some existing PRs being autoclosed and replacements opened.
rarkins pushed a commit that referenced this issue Aug 17, 2021
@stroncium @rarkins
fix: remove double hyphens from branch names (#11186)
41c17d7 
Removes double or more hyphens from branch names and replaces with a single hyphen.

Closes #8260

BREAKING CHANGE: Branches with double hyphens will be changed to single hyphens, which can result in some existing PRs being autoclosed and replacements opened.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 26.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core:dashboard Related to Dependency Dashboard functionality good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove double hyphens from branch names stroncium/renovate
3 participants
@viceice @rarkins @renovate-release