fix(repology): Properly handle of response with multiple package versions #8489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (#8482) Some repos produce multiple versions, and while not all of them can be downloaded, it should not result in invalid result at all. Instead all found versions that match criteria should be returned from data source just like in more regular one like npm or maven
…ions (#8482) cleaned up tests and snapshot expectations
|
@danez could you also add your review? |
danez
reviewed
Feb 2, 2021
Co-authored-by: Daniel Tschinder <duck+github@mailbox.org>
|
Can someone test this on a real repo first before we merge? |
|
@rarkins are you looking for real project or test repository showing that change works properly will do? |
|
Test repository is fine, as long as it validates both list and non-list return types |
|
@rarkins test repository - https://github.com/zeldigas/renovate-repology It has 2 packages to update - version of jdk in alpine (worked prior to PR as repology returns one version) and version of jdk for centos_8 (does not work without PR). Right now it works (see associated PRs). Log can be found here: https://pastebin.com/FMTLW4JZ |
|
Thanks, @zeldigas |
|
🎉 This PR is included in version 24.35.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Some repos available in repology api produce multiple versions, and while not all of them can be downloaded, it should not result in invalid result at all. Instead all found versions that match criteria should be returned from data source just like in more regular one like npm or maven.
This change adjust handling of multiple returned versions and produce all of them as result after filtering by repo and package types
Context:
Closes #8482
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: