Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename ensureMasterIssue #10260

Merged
merged 1 commit into from
Jun 1, 2021
Merged

chore: rename ensureMasterIssue #10260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions lib/workers/repository/dependency-dashboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function dryRun(
) {
jest.clearAllMocks();
setAdminConfig({ dryRun: true });
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(
ensureIssueClosingCalls
);
Expand All @@ -53,7 +53,7 @@ describe(getName(), () => {
});
it('do nothing if masterissue is disable', async () => {
const branches: BranchConfig[] = [];
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(0);
expect(platform.getBranchPr).toHaveBeenCalledTimes(0);
Expand All @@ -75,7 +75,7 @@ describe(getName(), () => {
dependencyDashboardApproval: false,
},
];
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(0);
expect(platform.getBranchPr).toHaveBeenCalledTimes(0);
Expand All @@ -89,7 +89,7 @@ describe(getName(), () => {
const branches: BranchConfig[] = [];
config.dependencyDashboard = true;
config.dependencyDashboardAutoclose = true;
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(1);
expect(platform.ensureIssueClosing.mock.calls[0][0]).toBe(
config.dependencyDashboardTitle
Expand Down Expand Up @@ -118,7 +118,7 @@ describe(getName(), () => {
];
config.dependencyDashboard = true;
config.dependencyDashboardAutoclose = true;
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(1);
expect(platform.ensureIssueClosing.mock.calls[0][0]).toBe(
config.dependencyDashboardTitle
Expand All @@ -135,7 +135,7 @@ describe(getName(), () => {
const branches: BranchConfig[] = [];
config.dependencyDashboard = true;
config.dependencyDashboardFooter = 'And this is a footer';
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand All @@ -158,7 +158,7 @@ describe(getName(), () => {
{},
];
config.dependencyDashboardFooter = 'And this is a footer';
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -232,7 +232,7 @@ describe(getName(), () => {
},
];
config.dependencyDashboard = true;
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -272,7 +272,7 @@ describe(getName(), () => {
platform.getBranchPr
.mockResolvedValueOnce({ ...mock<Pr>(), number: 1 })
.mockResolvedValueOnce(undefined);
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -322,7 +322,7 @@ describe(getName(), () => {
.mockResolvedValueOnce({ ...mock<Pr>(), number: 1 })
.mockResolvedValueOnce(undefined)
.mockResolvedValueOnce({ ...mock<Pr>(), number: 3 });
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -366,7 +366,7 @@ describe(getName(), () => {
.mockResolvedValueOnce({ ...mock<Pr>(), number: 1 })
.mockResolvedValueOnce(undefined)
.mockResolvedValueOnce({ ...mock<Pr>(), number: 3 });
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -424,7 +424,7 @@ describe(getName(), () => {
];
config.dependencyDashboard = true;
config.dependencyDashboardPrApproval = true;
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].title).toBe(
Expand Down Expand Up @@ -483,7 +483,7 @@ describe(getName(), () => {
},
]);
config.dependencyDashboard = true;
await dependencyDashboard.ensureMasterIssue(config, branches);
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssue).toHaveBeenCalledTimes(1);
expect(platform.ensureIssue.mock.calls[0][0].body).toMatchSnapshot();
});
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/dependency-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function appendRepoProblems(config: RenovateConfig, issueBody: string): string {
return newIssueBody;
}

export async function ensureMasterIssue(
export async function ensureDependencyDashboard(
config: RenovateConfig,
branches: BranchConfig[]
): Promise<void> {
Expand Down
4 changes: 2 additions & 2 deletions lib/workers/repository/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { deleteLocalFile, privateCacheDir } from '../../util/fs';
import * as queue from '../../util/http/queue';
import { addSplit, getSplits, splitInit } from '../../util/split';
import { setBranchCache } from './cache';
import { ensureMasterIssue } from './dependency-dashboard';
import { ensureDependencyDashboard } from './dependency-dashboard';
import handleError from './error';
import { finaliseRepo } from './finalise';
import { initRepo } from './init';
Expand Down Expand Up @@ -56,7 +56,7 @@ export async function renovateRepository(
}
logger.debug(`Automerged but already retried once`);
} else {
await ensureMasterIssue(config, branches);
await ensureDependencyDashboard(config, branches);
}
await finaliseRepo(config, branchList);
repoResult = processResult(config, res);
Expand Down