Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/maven): look for maven snapshot pom #11326

Closed

Conversation

bpfoster
Copy link
Contributor

Maven snapshot poms are stored in the repository with timestamp & build number replacing the -SNAPSHOT in the name.

The check for missing artifacts did not resolve these files and so SNAPSHOTS always appeared missing and were filtered out.

Not sure if the async handling in filterMissingArtifacts() is the best, please let me know if changes needed.

Changes:

Maven snapshot dependencies should now be included without wholesale disabling the pom check via RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK.

Context:

This should fix issue #3728

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Maven snapshot poms are stored in the repository with timestamp & build
number replacing the -SNAPSHOT in the name.

The check for missing artifacts did not resolve these files and so
SNAPSHOTS always appeared missing and were filtered out.
@bpfoster bpfoster closed this Aug 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant