Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): add node datasource #11651

Merged
merged 2 commits into from Sep 9, 2021
Merged

feat(datasource): add node datasource #11651

merged 2 commits into from Sep 9, 2021

Conversation

@viceice
Copy link
Collaborator

@viceice viceice commented Sep 9, 2021

Changes:

Add a new node datasource

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
@viceice viceice requested a review from rarkins Sep 9, 2021
@rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 9, 2021

What improvements / changes does this offer compared to the GitHub releases from the same repo?

@viceice
Copy link
Collaborator Author

@viceice viceice commented Sep 9, 2021

The binaries are available. The github release is probably a few hours ahead of the binaries. That's why we used docker datasource before to ensure binaries are available

rarkins
rarkins approved these changes Sep 9, 2021
@viceice viceice merged commit 922a36c into main Sep 9, 2021
8 checks passed
@viceice viceice deleted the feat/node-ds branch Sep 9, 2021
@renovate-release
Copy link
Collaborator

@renovate-release renovate-release commented Sep 9, 2021

🎉 This PR is included in version 27.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants