Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): support setting executable bit #12085

Merged
merged 5 commits into from
Oct 9, 2021
Merged

Conversation

ylemkimon
Copy link
Contributor

Changes:

Support setting the executable bit (chmod +x) in git.commitFiles()

Context:

Sometimes, there is a need to set the executable bit in committed files, e.g., binary files.

This is a blocking issue for #11368.

The actual mode of the written file cannot be tested as:

  • umask of test environments may vary
  • some file systems including Windows don't support the mode

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Windows and macOS tests: https://github.com/ylemkimon/renovate/actions/runs/1322981586

@rarkins
Copy link
Collaborator

rarkins commented Oct 9, 2021

I updated the workflows to add mac, windows. Should fail this one: https://github.com/ylemkimon/renovate/runs/3845610602?check_suite_focus=true

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but workflows need to be reverted.

@rarkins rarkins enabled auto-merge (squash) October 9, 2021 08:53
@rarkins rarkins merged commit d55650f into renovatebot:main Oct 9, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.31.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants