New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gomod): Add GOPROXY caching #12232
Conversation
Caches version list for an hour but each individual version (release timestamp) for a day? |
Can you work out a way to store the full result - including versions - for an hour? e.g. right now I think that if you have a package with 100 versions the you're still going to hit our cache 101 times every lookup, when 1 would do. |
Just tested with real repo: https://github.com/renovate-testing/test-12229-go-storage |
Now I'm about to cache the entire result, preserving achieved behavior |
Yes, I confirmed locally that it saves the goproxy from getting hit, but it currently hits our cache once per version. |
Did this change remove the 24 hour version caching? |
Yes, I'm trying to make single cache which is available for 1 hours. Maybe, make timeout value higher? Or do you mean to use different mechanism? |
Ok leave it as is for now |
🎉 This PR is included in version 28.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Cache version list and individual version responses from goproxy.
Context:
Closes #12229
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: