fix(gomod): remove token encoding

lib/util/git/auth.spec.ts

@@ -31,6 +31,20 @@ describe('util/git/auth', () => {
       });
     });
 
+    it('returns correct url if token already contains GitHub App username', () => {
+      expect(
+        getGitAuthenticatedEnvironmentVariables(
+          'https://github.com/',
+          'x-access-token:token:1234'
+        )
+      ).toStrictEqual({
+        GIT_CONFIG_KEY_0:
+          'url.https://x-access-token:token%3A1234@github.com/.insteadOf',
+        GIT_CONFIG_VALUE_0: 'https://github.com/',
+        GIT_CONFIG_COUNT: '1',
+      });
+    });
+
     it('returns url with token and already existing GIT_CONFIG_COUNT from parameter', () => {
       expect(
         getGitAuthenticatedEnvironmentVariables(

lib/util/git/auth.ts

@@ -1,6 +1,17 @@
 import { logger } from '../../logger';
 import { getHttpUrl } from './url';
 
+function encodeToken(token: string): string {
+  // if the token already starts with the `x-access-token:` username we encode only the token part
+  // This ensures that GitHub Apps work
+  if (token.startsWith('x-access-token:')) {
+    const appToken = token.replace('x-access-token:', '');
+    return `x-access-token:${encodeURIComponent(appToken)}`;
+  }
+
+  return encodeURIComponent(token);
+}
+
 /*
     Add authorization to a Git Url and returns the updated environment variables
 */
@@ -24,7 +35,7 @@ export function getGitAuthenticatedEnvironmentVariables(
     }
   }
 
-  const gitUrlWithToken = getHttpUrl(gitUrl, encodeURIComponent(token));
+  const gitUrlWithToken = getHttpUrl(gitUrl, encodeToken(token));
 
   // create a shallow copy of the environmentVariables as base so we don't modify the input parameter object
   // add the two new config key and value to the returnEnvironmentVariables object