-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workers/global): check git at startup #12935
feat(workers/global): check git at startup #12935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small thing
🎉 This PR is included in version 29.35.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What specifically in git 2.33.0 is required? It's not available in Debian stable repositories https://packages.debian.org/bullseye/git |
Blobless clone filtering and improvements to enable sparse checkout. This requirement cannot be relaxed and has previously been documented, but now it's finally detected at startup |
Do you prefer anyone that uses |
Compile git yourselves, or run it as a Docker image instead. Renovate heavily uses git, and will continue to utilize quite recent versions going forward, and this is therefore a requirement of using Renovate.
No, because we need functionality from the minimum version of git specified. Without it, people will sometimes get weird errors and waste both their time and ours trying to work out why. |
This fails in node:17 image based on bullseye, and an apt update/upgrade shows the latest git version is installed. short of now producing your own images, you cannot go further until the git binary has been updated. bullseye: https://packages.debian.org/bullseye/git |
Use Please use GitHub discussion for further messages. |
git 2.33.0 has been a documented requirement since 27.0.0 |
Changes:
Check Git version at startup #11167. It requires testing on Windows CI as discussed previously.
Context:
Closes #11167
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: