Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): support binarySource=install #13719

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 21, 2022

Changes:

Refactors helm install in helmv3 artifacts to support binarySource=install.

Context:

Part of #13683

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice January 21, 2022 13:20
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 21, 2022

Not tested on a "real" repo and I don't have any reproductions to verify it against

viceice
viceice previously approved these changes Jan 21, 2022
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work

@rarkins rarkins enabled auto-merge (squash) January 21, 2022 14:28
# Conflicts:
#	lib/manager/helmv3/__snapshots__/artifacts.spec.ts.snap
#	lib/manager/helmv3/artifacts.spec.ts
#	lib/manager/helmv3/artifacts.ts
@rarkins rarkins requested a review from viceice January 28, 2022 12:59
auto-merge was automatically disabled January 28, 2022 12:59

Pull Request is not mergeable

@rarkins rarkins enabled auto-merge (squash) January 28, 2022 13:18
auto-merge was automatically disabled January 28, 2022 13:18

Pull Request is not mergeable

@rarkins rarkins changed the title feat: binarySource=install for helm feat(helm): support binarySource=install Jan 28, 2022
@rarkins rarkins enabled auto-merge (squash) January 28, 2022 13:22
@rarkins rarkins merged commit 3144a48 into main Jan 28, 2022
@rarkins rarkins deleted the feat/helm-binary-source-install branch January 28, 2022 13:30
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants