Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(manager/helmv3): migrate from fs.readFile to fs.readLocalFile #13832

Merged
merged 9 commits into from Jan 31, 2022
Merged

test(manager/helmv3): migrate from fs.readFile to fs.readLocalFile #13832

merged 9 commits into from Jan 31, 2022

Conversation

olegkrivtsov
Copy link
Contributor

@olegkrivtsov olegkrivtsov commented Jan 26, 2022 •
edited

Changes:

migrate from fs.readFile to fs.readLocalFile (helmv3) #12987

Context:

Part of #7049, related to PR #12987

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs lint fixes too

lib/manager/helmv3/__snapshots__/artifacts.spec.ts.snap Outdated Show resolved Hide resolved
lib/manager/helmv3/artifacts.spec.ts Show resolved Hide resolved
@olegkrivtsov
Copy link
Contributor Author

Hi @viceice the build has failed on e2e tests, but I'm not sure how to fix the problem. Can you advice?

viceice
viceice reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a temporary issue. This needs deconflicting now.

viceice
viceice reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs snapshot updates

@olegkrivtsov
Copy link
Contributor Author

Hi @viceice I see some strange CodeQL build error, but I have no idea what could create it...

@viceice viceice changed the title feat(manager/helmv3): migrate from fs.readFile to fs.readLocalFile test(manager/helmv3): migrate from fs.readFile to fs.readLocalFile Jan 31, 2022
@viceice viceice enabled auto-merge (squash) January 31, 2022 13:42
@viceice viceice merged commit cb6401e into renovatebot:main Jan 31, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.64.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olegkrivtsov @renovate-release @viceice @rarkins