Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flutter-version datasource #14743

Merged
merged 15 commits into from
Mar 29, 2022
Merged

feat: add flutter-version datasource #14743

merged 15 commits into from
Mar 29, 2022

Conversation

zeshuaro
Copy link
Contributor

Changes

Context

Close #12820

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required (not sure if I need to add a README for this new datasource)

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zeshuaro
Copy link
Contributor Author

I included the full API response for the test, not sure if we need it or a subset of it would be sufficient.

@viceice viceice self-requested a review March 21, 2022 17:33
@rarkins
Copy link
Collaborator

rarkins commented Mar 21, 2022

Is this datasource for the version of Flutter itself? For other similar ones we use a -version suffix to try to avoid confusion, e.g.

image

lib/modules/datasource/flutter/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter/types.ts Outdated Show resolved Hide resolved
@zeshuaro zeshuaro requested a review from viceice March 22, 2022 08:00
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can apply all suggestions as batch from github review page 😉

lib/modules/datasource/flutter-version/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/types.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/types.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/types.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/api.ts Outdated Show resolved Hide resolved
lib/modules/datasource/api.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/index.spec.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title feat: add flutter datasource feat: add flutter-version datasource Mar 22, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zeshuaro
Copy link
Contributor Author

zeshuaro commented Mar 22, 2022

Thanks for sharing the batch commit trick, I didn't know we can do that on GitHub.

So after these changes are merged, I assume this would unblock two other issues related to update the pubspec.lock file. I can see that you already have a PR up in the buildpack repo, will you have time to follow-up on that work? Otherwise, I'm happy to help out as well.

@zeshuaro zeshuaro requested a review from viceice March 22, 2022 09:20
@zeshuaro zeshuaro requested a review from viceice March 22, 2022 12:32
rarkins
rarkins previously approved these changes Mar 28, 2022
lib/util/regex.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly done

lib/modules/datasource/flutter-version/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/flutter-version/index.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) March 29, 2022 03:52
@viceice viceice merged commit e244128 into renovatebot:main Mar 29, 2022
@zeshuaro zeshuaro deleted the feat/flutter-datasource branch March 29, 2022 04:12
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add flutter-version datasource
4 participants