Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vulnerabilities): add feature-flagged support for osv #15159

Closed
wants to merge 2 commits into from

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Apr 17, 2022

Changes

  • Added osvVulnerabilityAlerts option as experimental and default false
  • Lookup vulnerabilities for top-level packages during lookup phase

Examples:

NOTE: This does not provide vulnerability updates for transitive dependencies. GitHub Security Advisories does do this, but currently Renovate does not extract dependencies from lockfiles, for example package-lock.json. So, at this point in the Renovate run we cannot lookup vulnerabilities for transitive dependencies.

Context

#6562

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

(Will provide updated documentation once the feature is listed)

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/workers/repository/process/vulnerabilities.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Shegox Shegox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool feature, looking forward to seeing that.
Is there anything I can test or help out with?

lib/config/options/index.ts Outdated Show resolved Hide resolved
@JamieMagee JamieMagee dismissed a stale review via 946cb84 August 19, 2022 23:02
@JamieMagee JamieMagee changed the title feat: add feature-flagged support for osv feat(vulnerabilities): add feature-flagged support for osv Oct 9, 2022
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to go.

`${vulnerability.summary ?? ''}`,
'<details><summary>More information</summary>',
`## Details\n${vulnerability.details ?? 'No details'}
## Severity\n${vulnerability.severity?.[0].score ?? 'No severity'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'Unknown severity' more accurately portraits the situation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe No severity specified?

@JamieMagee
Copy link
Contributor Author

Superseded by #20226

@JamieMagee JamieMagee closed this Feb 6, 2023
@rarkins rarkins deleted the osv-vulnerabilities branch February 23, 2023 08:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants