-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource:terraform): use official api for custom registries #15175
feat(datasource:terraform): use official api for custom registries #15175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please trim sample JSON fixture to have less versions.
@viceice I've reduced the size of the samples - just so you know, still changes the snapshots as the versions are in a random order in that response, so i've just left the first couple of 100 lines. |
that's fine |
8967ee1
to
178abd8
Compare
@viceice so I've made a new commit - new try - this probably makes sense - tries the current endpoint first and if it doesnt work tries the documented api. |
changes the terraform module and provider to try loading from basic spec registry
80ac660
to
9866cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Any update on this? I think all the comments have been addressed @viceice |
This reverts commit 2729fdc.
Head branch was pushed to by a user without write access
@viceice i guess something is wrong that it doesnt auto merge |
nope, needs update from main. 😉 |
🎉 This PR is included in version 32.57.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
changes the terraform module and provider loading to try to use use the versions endpoint as per the spec, if the extended api isn't available.
The current code uses extensions to the spec, that are supported by registry.terraform.io, but not all third parties, e.g. GitLab. This will allow loading version info for modules hosted on GitLab and other registries that support the basic spec.
Also new endpoint doesn't have release date information, so thats now omitted when using these endpoints.
Context
Fixes #14602
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: