Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add option endpoint to global config #15843

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • add endpoint as an option in GlobalConfig and as a property in RepoGlobalConfig, GlobalOnlyConfig
  • add minimal test for endpoint

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also add the functionality to use endpoint from global config in this same PR

lib/config/types.ts Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 2, 2022

I think you should also add the functionality to use endpoint from global config in this same PR

You mean the function in gitlab-tags which checks for platform & returns endpoint incase of gitlab.

@rarkins
Copy link
Collaborator

rarkins commented Jun 2, 2022

Actually, it's fine for now - do it as the next step.

@rarkins rarkins merged commit bd6e422 into renovatebot:main Jun 2, 2022
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins this will now remove endpoint from RenovateConfig so all code which depends on that will fail ( changelogs as example)

@viceice
Copy link
Member

viceice commented Jun 2, 2022

delete result[option];

@rarkins
Copy link
Collaborator

rarkins commented Jun 3, 2022

Reverted

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.71.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants