feat(manager/fleet): implement Rancher Fleet manager - #16138
Merged
Conversation
HonkingGoose
suggested changes
Jun 19, 2022
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
previously approved these changes
Jun 20, 2022
viceice
reviewed
Jun 21, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Member
Author
|
@nabeelsaabna friendly ping regarding review. |
Contributor
nabeelsaabna
left a comment
nabeelsaabna
left a comment
Contributor
There was a problem hiding this comment.
I prefer dep or result rather than tempDep (personal taste)
other than that everything LGTM
nabeelsaabna
previously approved these changes
Jul 14, 2022
viceice
reviewed
Jul 21, 2022
viceice
requested changes
Jul 24, 2022
viceice
reviewed
Jul 26, 2022
viceice
approved these changes
Jul 26, 2022
viceice
enabled auto-merge (squash)
July 26, 2022 08:14
|
🎉 This PR is included in version 32.130.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new manager for
Rancher FleetContext
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/secustor/16051