Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/fleet): implement Rancher Fleet manager #16138

Merged
merged 18 commits into from Jul 26, 2022
Merged

feat(manager/fleet): implement Rancher Fleet manager #16138

merged 18 commits into from Jul 26, 2022

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Jun 19, 2022 •
edited by viceice

Changes

Adds a new manager for Rancher Fleet

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/16051

@secustor secustor requested a review from viceice June 19, 2022 11:30
HonkingGoose
HonkingGoose suggested changes Jun 19, 2022
View reviewed changes
lib/modules/manager/fleet/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/fleet/readme.md Outdated Show resolved Hide resolved
@secustor @HonkingGoose
Apply suggestions from code review
e358e57 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
HonkingGoose previously approved these changes Jun 20, 2022
View reviewed changes
viceice
viceice reviewed Jun 21, 2022
View reviewed changes
lib/modules/manager/fleet/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/types.ts Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Show resolved Hide resolved
@secustor
Copy link
Collaborator Author

@nabeelsaabna friendly ping regarding review.

@nabeelsaabna
Copy link
Contributor

hi @secustor, I believe it was covered by @viceice, therefore I didn't comment
will take a look as well 👍

nabeelsaabna
nabeelsaabna reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@nabeelsaabna nabeelsaabna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer dep or result rather than tempDep (personal taste)
other than that everything LGTM

nabeelsaabna
nabeelsaabna previously approved these changes Jul 14, 2022
View reviewed changes
@secustor secustor requested a review from viceice July 19, 2022 11:15
viceice
viceice reviewed Jul 21, 2022
View reviewed changes
lib/modules/manager/fleet/extract.ts Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice July 23, 2022 20:00
viceice
viceice requested changes Jul 24, 2022
View reviewed changes
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice July 25, 2022 13:11
viceice
viceice reviewed Jul 26, 2022
View reviewed changes
lib/modules/manager/fleet/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.spec.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice July 26, 2022 07:27
@viceice viceice enabled auto-merge (squash) July 26, 2022 08:14
@viceice viceice merged commit 90f85b9 into renovatebot:main Jul 26, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.130.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
@secustor secustor deleted the feat_implement_fleet branch December 4, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose HonkingGoose left review comments

@nabeelsaabna nabeelsaabna nabeelsaabna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Rancher Fleet definitions
5 participants
@secustor @nabeelsaabna @renovate-release @viceice @HonkingGoose