Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hermit package manager #16258

Merged

Conversation

lyonlai
Copy link
Contributor

@lyonlai lyonlai commented Jun 27, 2022

Changes

As part of the Hermit manager feature from #16250, this PR contains the manager component used by Hermit package manager.

Context

Issue: #16119
PR: #16250

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/update.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Outdated Show resolved Hide resolved
* add docker support in exec
* move fs related operations back into  util/fs
* remove ENVVar passed on by process.env
* set concurrency in pMap
* use for instead of pMap for concurrency = 1
* use regex to pick up package reference parts
PhilipAbed
PhilipAbed previously approved these changes Jun 30, 2022
Copy link
Collaborator

@PhilipAbed PhilipAbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PhilipAbed PhilipAbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests and other checks, other stuff looks good to me

lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
@lyonlai
Copy link
Contributor Author

lyonlai commented Jul 5, 2022

datasource & versioning PRs needs to be merged for the tests to pass in this PR.

lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
* test refer to internal fs
* docker image change to sidecar
* only symlink are read for the changed file content after hermit
  install
* no more global mock in artifacts test
@lyonlai lyonlai requested a review from viceice July 7, 2022 01:20
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/util/fs/index.ts Outdated Show resolved Hide resolved
lib/util/fs/index.spec.ts Outdated Show resolved Hide resolved
lib/util/fs/__snapshots__/index.spec.ts.snap Outdated Show resolved Hide resolved
lib/modules/manager/hermit/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Show resolved Hide resolved
@lyonlai lyonlai requested a review from viceice July 20, 2022 04:39
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/types.ts Outdated Show resolved Hide resolved
lib/util/fs/index.ts Outdated Show resolved Hide resolved
lyonlai and others added 2 commits July 21, 2022 15:07
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/artifacts.spec.ts Show resolved Hide resolved
lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/extract.ts Outdated Show resolved Hide resolved
lyonlai and others added 3 commits July 26, 2022 16:06
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
@lyonlai lyonlai requested a review from viceice July 26, 2022 08:37
@lyonlai
Copy link
Contributor Author

lyonlai commented Jul 27, 2022

@viceice are we still waiting for anything else in this PR?

lib/modules/manager/hermit/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/hermit/index.ts Outdated Show resolved Hide resolved
@lyonlai lyonlai requested a review from viceice July 30, 2022 04:12
@viceice viceice enabled auto-merge (squash) July 30, 2022 08:30
@viceice viceice merged commit b696abb into renovatebot:main Jul 30, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.135.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants