-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Hermit package manager #16258
feat: add Hermit package manager #16258
Conversation
* add docker support in exec * move fs related operations back into util/fs * remove ENVVar passed on by process.env * set concurrency in pMap * use for instead of pMap for concurrency = 1 * use regex to pick up package reference parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix tests and other checks, other stuff looks good to me
Co-authored-by: Philip <42116482+PhilipAbed@users.noreply.github.com>
|
* test refer to internal fs * docker image change to sidecar * only symlink are read for the changed file content after hermit install * no more global mock in artifacts test
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
@viceice are we still waiting for anything else in this PR? |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 32.135.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
As part of the Hermit manager feature from #16250, this PR contains the manager component used by Hermit package manager.
Context
Issue: #16119
PR: #16250
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: