Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): fix recursive resolved dependencies #16462

Merged
merged 31 commits into from
Jul 24, 2022
Merged

fix(bundler): fix recursive resolved dependencies #16462

merged 31 commits into from
Jul 24, 2022

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 7, 2022 •
edited by viceice

Changes

  • Add more tests
  • Fix types and code

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

zharinov commented Jul 7, 2022

Example: renovate-testing/test-15949-renovate-bundler-recursive#4

@zharinov zharinov mentioned this pull request Jul 7, 2022
Closed
6 tasks
@zharinov zharinov requested review from viceice and rarkins July 7, 2022 08:13
viceice
viceice reviewed Jul 7, 2022
View reviewed changes
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 7, 2022 13:52
viceice
viceice reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove all dummy resolve, the default mock should do it for tests

lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/artifacts.spec.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 9, 2022 11:35
rarkins
rarkins requested changes Jul 10, 2022
View reviewed changes
lib/modules/manager/bundler/artifacts.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Jul 10, 2022
View reviewed changes
@viceice viceice requested a review from rarkins July 10, 2022 13:58
rarkins
rarkins requested changes Jul 10, 2022
View reviewed changes
lib/modules/manager/bundler/artifacts.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jul 19, 2022
View reviewed changes
@rarkins rarkins enabled auto-merge (squash) July 19, 2022 04:52
auto-merge was automatically disabled July 21, 2022 13:44

Head branch was pushed to by a user without write access

@zharinov zharinov dismissed stale reviews from rarkins and viceice via 98a2d20 July 21, 2022 13:44
@zharinov zharinov requested review from viceice and rarkins July 21, 2022 13:57
@zharinov
Copy link
Collaborator Author

😬

@zharinov
Merge branch 'main' into fix/bundler-recursive-artifact-update
2a77f7b 
# Conflicts:
#	lib/modules/manager/bundler/__snapshots__/artifacts.spec.ts.snap
@zharinov zharinov force-pushed the fix/bundler-recursive-artifact-update branch from ef6be05 to 2a77f7b Compare July 21, 2022 14:07
@rarkins rarkins marked this pull request as draft July 22, 2022 05:26
@zharinov zharinov marked this pull request as ready for review July 22, 2022 15:07
@zharinov
fix
f1bca6c
@zharinov
Merge branch 'fix/bundler-recursive-artifact-update' of github.com:zh…
0139c7e 
…arinov/renovate into fix/bundler-recursive-artifact-update
@zharinov zharinov marked this pull request as draft July 22, 2022 15:40
@zharinov zharinov marked this pull request as ready for review July 22, 2022 16:54
@viceice viceice enabled auto-merge (squash) July 24, 2022 07:30
@viceice viceice merged commit 6e01af9 into renovatebot:main Jul 24, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.126.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zharinov zharinov deleted the fix/bundler-recursive-artifact-update branch July 25, 2022 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error trying to run bundle lock --update undefined
4 participants
@zharinov @renovate-release @viceice @rarkins