Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run prettier on migratedJSON #16471

Merged
merged 31 commits into from
Jul 14, 2022
Merged

feat: run prettier on migratedJSON #16471

merged 31 commits into from
Jul 14, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • add readLocalPath function to get local path of file from localDir
  • run prettier using user's default setting on migratedJSON

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 7, 2022 15:39
viceice
viceice requested changes Jul 7, 2022
View reviewed changes
lib/util/git/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lib/util/git/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 7, 2022 19:15
zharinov
zharinov previously approved these changes Jul 9, 2022
View reviewed changes
@rarkins
Copy link
Collaborator

rarkins commented Jul 12, 2022

Please perform extensive testing once we reach a final version

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 12, 2022 06:15
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jul 13, 2022 •
edited

Tested for these cases:-
No_indent defaults to 2 spaces
: https://github.com/RahulGautamSingh-testing/migrate_no_indentation/

uses same indentation ie. detected amount, tabs & spaces:
https://github.com/RahulGautamSingh-testing/tabs_present/
https://github.com/RahulGautamSingh-testing/spaces-3/

random_formatting defaults to 2 spaces and works for json5 :
https://github.com/RahulGautamSingh-testing/random_formatting

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 13, 2022 04:42
@viceice
Copy link
Member

viceice commented Jul 13, 2022

I've not checked the samples, so @rarkins merge when you're confident.

@rarkins rarkins enabled auto-merge (squash) July 14, 2022 05:55
@rarkins rarkins merged commit 2d5c823 into renovatebot:main Jul 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.114.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 14, 2022
Closed
Open
@viceice viceice linked an issue Jul 14, 2022 that may be closed by this pull request
Config migration: run prettier #16402
Closed
@viceice
Copy link
Member

viceice commented Jul 14, 2022

@RahulGautamSingh Please don't forget to add fixes or closes keywords to automatically close related issues 😉

@viceice viceice mentioned this pull request Jul 19, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zharinov zharinov zharinov approved these changes

@astellingwerf astellingwerf astellingwerf approved these changes

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config migration: run prettier
6 participants
@RahulGautamSingh @rarkins @viceice @renovate-release @zharinov @astellingwerf