Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-validator): read filenames from CLI arguments #16475

Merged
merged 7 commits into from Aug 4, 2022
Merged

feat(config-validator): read filenames from CLI arguments #16475

merged 7 commits into from Aug 4, 2022

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Jul 7, 2022

Changes

Validate files passed as arguments

Context

Closes renovatebot/pre-commit-hooks#341

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/config-validator.ts Outdated Show resolved Hide resolved
lib/config-validator.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs docs added or updated

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

lib/config-validator.ts Outdated Show resolved Hide resolved
@maxbrunet maxbrunet requested a review from viceice July 20, 2022 19:12
@rarkins rarkins enabled auto-merge (squash) August 4, 2022 06:12
@rarkins rarkins merged commit cbe8bfc into renovatebot:main Aug 4, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.144.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
@maxbrunet maxbrunet deleted the feat/config-validator-argv branch November 24, 2022 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants