-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource/docker): add support for architecture-specific image digests #16554
Conversation
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Thanks for the hint on the I've now added a |
@viceice, I think we have a different understanding of how to get the architecture. Based on your comments, I believe you think one could get the architecture also from the digest, which is not the case. ExampleLet's take
The mapping of digests to architecture is only retrievable by querying the
Architecture-Lookup Flow
I hope this helps to clarify things a bit 😊 |
as i sad in comment, current value probably no longer point to the original manifest list, docker tags are floating. so algorithm should be:
|
Thanks for the info regarding image config. I've now adapted the implementation to that. Moreover:
In a follow-up PR (or this one, depending on your preference), |
# Conflicts: # lib/modules/datasource/docker/index.ts
please validate latest changes against real repo, should test all scenarios |
I have now re-run the latest version on the two test repositories: working as expected.
|
i expect a pin PR would also use the manifest list digest, it's same case as no current digest? |
My bad, I was missing the |
🎉 This PR is included in version 32.163.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Test repositories:
Note: I'm not sure if the changes to the caching key are correct, necessary and effective. Any insights will be appreciated.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: