New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(util/template): add prettyVersion field #16831
Conversation
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e/renovate into fix-v-in-version
@HonkingGoose what do you think of the docs change ? |
May I suggest you update the PR title to 'prepend' instead of 'append'? |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
How does this compare in ease of use to just using a replace helper? Or does it not support regex ^? |
You mean to expose a function to users that replaces strings ? |
We already expose a replace function |
Why not the prettyX strings we discussed previously? If it's a common use case then let's just prepopulate them |
@rarkins It is the same as we discussed in the issue I just named it
or on
|
Why not just prettyVersion etc? I don't think we discussed which is better for the end user or maintainability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plans for prettyNewMajor too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 32.152.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Exposed a handlebars function to enable prettifying
newVersion
andnewMajor
.Context
Closes #13299
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: