Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/sbt): allow addCompilerPlugin #17006

Merged
merged 5 commits into from
Aug 7, 2022

Conversation

cjtim
Copy link
Contributor

@cjtim cjtim commented Aug 5, 2022

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should have a test

@cjtim cjtim requested a review from viceice August 5, 2022 16:20
@cjtim cjtim changed the title fix(sbt/manager): allow addCompilerPlugin fix(manager/sbt): allow addCompilerPlugin Aug 5, 2022
@rarkins rarkins requested a review from zharinov August 6, 2022 09:11
zharinov
zharinov previously approved these changes Aug 6, 2022
@cjtim
Copy link
Contributor Author

cjtim commented Aug 6, 2022

@zharinov I fix the test snapshot. please approve again thank you.

zharinov
zharinov previously approved these changes Aug 6, 2022
viceice
viceice previously approved these changes Aug 6, 2022
@viceice viceice enabled auto-merge (squash) August 6, 2022 10:12
auto-merge was automatically disabled August 6, 2022 14:09

Head branch was pushed to by a user without write access

@cjtim cjtim dismissed stale reviews from viceice and zharinov via 19a0cb2 August 6, 2022 14:09
@cjtim cjtim force-pushed the fix/sbt-addCompilerPlugin branch from c8a41d3 to 19a0cb2 Compare August 6, 2022 14:09
@cjtim
Copy link
Contributor Author

cjtim commented Aug 6, 2022

rebase and resolved conflict

@cjtim cjtim force-pushed the fix/sbt-addCompilerPlugin branch from 19a0cb2 to b989484 Compare August 7, 2022 04:25
@cjtim cjtim requested a review from viceice August 7, 2022 04:26
@viceice viceice enabled auto-merge (squash) August 7, 2022 05:25
@viceice viceice merged commit f61342d into renovatebot:main Aug 7, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.151.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants