fix(manager/git-submodule): use appropriate hostType for auth

[viceice]

Changes

• detect platform on sub-module manager and fallback to git-refs
• default branch works with platform host-rule works
• there are still issues:
  • if platform is detected, fetching updates doesn't work, as we always use git-refs host-type.

Context

• fixes [Bug] Git-submodule checkout om Gitlab stopped working with 32.110.2 #16561

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

@rarkins should we propably need to change this

renovate/lib/util/git/url.ts

Line 42 in a5b9ad0

const hostRule = hostRules.find({ url, hostType });

So if hostType=git-ref and we don't find auth, try to detect platform and use platform specific hostrule?
Or just always use git-refs and document on sub-modules manager, that we need a git-refs host-type or no host-type?

[astellingwerf]

Don't you agree the same fix could apply to the GitRefsDatasource and GitTagsDatasource?

[viceice]

Don't you agree the same fix could apply to the GitRefsDatasource and GitTagsDatasource?

that's not so easy, as they use static http classes, which passes the Host-Type via constructors

[viceice]

@rarkins WDYT?

[rarkins]

I really don't know, sorry. Haven't written or used this section of code

[viceice]

@JamieMagee WDYT?

[JamieMagee]

This looks reasonable, though from your description it might just push the issue to when updates are fetched?

[viceice]

This looks reasonable, though from your description it might just push the issue to when updates are fetched?

🤷‍♂️ not sure about a better solution

[ribtoks]

What is preventing this PR from being merged?

[renovate-release]

🎉 This PR is included in version 35.55.2 🎉

The release is available on:

• GitHub release
• 35.55.2

Your semantic-release bot 📦🚀