Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repo/cache): add s3 support for user configured folder hierarchy #18865

Merged
merged 9 commits into from
Nov 13, 2022
Merged

feat(repo/cache): add s3 support for user configured folder hierarchy #18865

merged 9 commits into from
Nov 13, 2022

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

Changes

Enables users to set the folder under which repo cache will be stored at.
This is set as part of the existing repositoryCacheType feature flag.

Approach taken as per -

In order to keep implementation simple I suggest enabling this only when the s3 "key" (in above case dir1/dir2/.../dir3/) ends with a trailing slash. that means that for repositoryCacheType: 's3://bucket/dir1/dir2/.../dir3/file.ext' we will ignore the key altogether and store cache directly under the given bucket.

Context

Closes #18864

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/cache/repository/impl/s3.ts Show resolved Hide resolved
@Gabriel-Ladzaretti @HonkingGoose
Update docs/usage/self-hosted-configuration.md
e09786f 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
HonkingGoose previously approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs.

viceice
viceice previously approved these changes Nov 11, 2022
View reviewed changes
rarkins
rarkins requested changes Nov 12, 2022
View reviewed changes
lib/util/cache/repository/impl/s3.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) November 13, 2022 08:59
@viceice viceice merged commit 991cc7a into renovatebot:main Nov 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

@nabeelsaabna nabeelsaabna nabeelsaabna approved these changes

@HonkingGoose HonkingGoose HonkingGoose left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 repository cache - support user configured folder hierarchy
5 participants
@Gabriel-Ladzaretti @viceice @rarkins @HonkingGoose @nabeelsaabna