chore: relative links for contribution guidelines #19715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lmilbaum
force-pushed
the
contribution
branch
2 times, most recently
from
d59324f
to
324e752
Compare
|
Thanks for the PR. How confident are you that these relative links work in every case? |
I am confident with the md files not in the .github folder. Not confident with the others. Didn't figure out yet how to validate them. Any idea? |
|
We can maybe manually edit some existing ones and test if it still works correctly afterwards |
|
Shell I close the PR? |
rarkins
requested changes
Jan 22, 2023
lmilbaum
force-pushed
the
contribution
branch
from
b258cc7
to
44b484c
Compare
rarkins
previously approved these changes
Jan 22, 2023
auto-merge was automatically disabled
January 22, 2023 17:58
Head branch was pushed to by a user without write access
lmilbaum
force-pushed
the
contribution
branch
from
44b484c
to
f1f30e9
Compare
rarkins
approved these changes
Jan 22, 2023
|
🎉 This PR is included in version 34.109.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: