Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): include replacements:all in config:base #20933

Merged

Conversation

fgreinacher
Copy link
Contributor

Changes

Include the replacements:all preset in the config:base preset as those replacements are generally applicable.

Context

Suggested at #20928 (comment).

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

馃洜 with 鉂わ笍 by Siemens

@fgreinacher fgreinacher marked this pull request as ready for review March 14, 2023 20:34
JamieMagee
JamieMagee previously approved these changes Mar 14, 2023
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending test fixes

@viceice viceice requested a review from rarkins March 14, 2023 23:01
@rarkins rarkins added this pull request to the merge queue Mar 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 15, 2023
@rarkins rarkins added this pull request to the merge queue Mar 15, 2023
Merged via the queue into renovatebot:main with commit ca03555 Mar 15, 2023
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 35.7.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@fgreinacher fgreinacher deleted the feat/replacements-in-config-base branch March 15, 2023 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants