Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/bitbucket-pipelines): add support for docker-based pipes #20938

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Mar 15, 2023

Changes

Adds support to bitbucket-pipelines for pipes which reference a Docker Image.

  • pipe: docker://foo ---> depType: docker

Context

Currently the bitbucket-pipelines manager only supports

  • image: foo ---> depType: docker
  • pipe: foo ---> depType: bitbucket-tags

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy requested a review from viceice March 15, 2023 03:59
rarkins
rarkins previously approved these changes Mar 15, 2023
@rarkins
Copy link
Collaborator

rarkins commented Mar 15, 2023

@secustor do we really want to make this breaking though? e.g. removal of these:

image

@secustor
Copy link
Collaborator

@secustor do we really want to make this breaking though? e.g. removal of these:

image

No, I have clarified here that we should remove this in a major #20938 (comment)

@rarkins
Copy link
Collaborator

rarkins commented Mar 15, 2023

@setchy I think we had some confusion. Can you roll back the changes to depType=docker so that this is non breaking?

@setchy
Copy link
Collaborator Author

setchy commented Mar 15, 2023

@setchy I think we had some confusion. Can you roll back the changes to depType=docker so that this is non breaking?

Apologies for the mixup. Good to go now 🤞

@setchy setchy requested a review from rarkins March 15, 2023 12:46
@setchy
Copy link
Collaborator Author

setchy commented Mar 16, 2023

@rarkins @secustor - third time's a charm - depType changes are back what's on main

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/bitbucket-pipelines/extract.ts Outdated Show resolved Hide resolved
secustor
secustor previously approved these changes Mar 16, 2023
@rarkins rarkins enabled auto-merge March 16, 2023 12:14
@rarkins rarkins added this pull request to the merge queue Mar 16, 2023
Merged via the queue into renovatebot:main with commit 5d82120 Mar 16, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the feature/bitbucket-pipelines-pipe-as-docker-image branch March 17, 2023 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
@setchy setchy added manager:bitbucket-pipelines Bitbucket pipelines manager type:feature Feature (new functionality) labels May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bitbucket-pipelines Bitbucket pipelines manager type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants