Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(versioning/regex): add revision as fifth capture group #21555

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 17, 2023

Changes

Allows to use revision as fifth capture group to allow updates of bitnami docker images.
eg bitnami/postgresql docker image 11.16.0-debian-10-r23 -> 11.16.0-debian-11-r33

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Apr 17, 2023

I don't object to this capability, but it looks like a secondary version/compatibility instead of a 5 part version

@viceice
Copy link
Member Author

viceice commented Apr 17, 2023

my use case is not compabillity, but have a handy possibility to not only update the bitnami revisition.

it's ok for me to have this a patch release because I've merging those manually.

@viceice
Copy link
Member Author

viceice commented Apr 17, 2023

this is just an easy workaround until we have time to implement the linked multi version issue

@rarkins rarkins added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 4fa199e Apr 18, 2023
6 checks passed
@rarkins rarkins deleted the feat/versioning/regex/fifth-capture-group branch April 18, 2023 02:57
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants