Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(date): Use Jest fake timers #21631

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

Sometimes CI randomly fails like this:

util/date › getElapsedMilliseconds › returns elapsed time in milliseconds

    expect(received).toBe(expected) // Object.is equality

    Expected: 9469618351
    Received: 9469618352

      44 |     it('returns elapsed time in milliseconds', () => {
      45 |       const elapsedMs = new Date().getTime() - new Date(Jan1).getTime();
    > 46 |       expect(getElapsedMs(Jan1.toISOString())).toBe(elapsedMs);
         |                                                ^
      47 |     });
      48 |   });
      49 | });

      at Object.<anonymous> (lib/util/date.spec.ts:46:48)

This PR should fix it.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins April 20, 2023 16:20
@rarkins rarkins enabled auto-merge April 20, 2023 16:34
@rarkins rarkins added this pull request to the merge queue Apr 20, 2023
Merged via the queue into renovatebot:main with commit 58fe0bd Apr 20, 2023
9 checks passed
@rarkins rarkins deleted the refactor/date-util-tests branch April 20, 2023 17:16
Comment on lines +20 to 22
afterAll(() => {
jest.useRealTimers();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed, as each test file is isolated

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.55.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants