Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/gradle): Filter false positives out of extracted deps #21753

Merged
merged 5 commits into from
Apr 23, 2023
Merged

fix(manager/gradle): Filter false positives out of extracted deps #21753

merged 5 commits into from
Apr 23, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Apr 22, 2023 •
edited

Changes

  • Dismiss foo('bar', 'baz', '<...>') and "bar:baz:<...>" dependencies based on whether version contains any numeric characters or not
  • Remove blocklist of methods that were leading to ignored skip reason

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from Churro and viceice April 22, 2023 16:07
viceice
viceice previously approved these changes Apr 22, 2023
View reviewed changes
Churro
Churro previously approved these changes Apr 22, 2023
View reviewed changes
lib/modules/manager/gradle/parser.spec.ts Outdated Show resolved Hide resolved
@zharinov zharinov dismissed stale reviews from Churro and viceice via 9da8fbf April 22, 2023 16:32
@zharinov zharinov changed the title refactor(manager/gradle): Dismiss ANNOYING_METHODS approach fix(manager/gradle): Filter false positives out of extracted deps Apr 22, 2023
@zharinov zharinov requested review from viceice and Churro April 22, 2023 16:35
@zharinov
Copy link
Collaborator Author

I think it's logically consistent to fix both cases in single PR, and close the original issue

@rarkins rarkins merged commit 6bd1277 into renovatebot:main Apr 23, 2023
9 checks passed
@rarkins rarkins deleted the refactor/gradle-remove-annoying-methods branch April 23, 2023 06:33
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.57.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@zharinov @mjunker
fix(manager/gradle): Filter false positives out of extracted deps (re…
ad8815b 
…novatebot#21753)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Churro Churro Churro approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle parser false positive dependency strings
5 participants
@zharinov @renovate-release @Churro @viceice @rarkins