fix(template): Proxy Compile Input loses values from arrays #21943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change prevents the values in
Array<string>
inputs (e.g.prBodyNotes
) from being stripped by theproxyCompileInput
/ allowed fields process.Context
I was trying to implement a "fallback" rule that provides general instructions if there aren't any other rules in place. Based on the documentation, I believe something like this should work.
Unfortunately, it rendered the fallback message even when another rule (that includes
prBodyNotes
) matches, indicating that theprBodyNotes
value is not being supplied in the template context.After having a look at the implementation and tests, I believe it is because the
proxyCompileInput
is dropping the values inprBodyNotes
when it attempts to recurse into the array. I don't believe this is intentional, asprBodyNotes
(et al) is listed in theexposedConfigOptions
.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: