Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add i am a maintainer checkbox to issue forms #22468

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Add a "I am a maintainer" checkbox to our issue forms

Context

I'm not sure if the checkbox is properly marked as mandatory, when I preview the forms on my branch I don't see the * that denotes it's mandatory...

I'm opening this PR because a user suggested adding a checkbox to the form here:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Comment on lines +18 to +19
validations:
required: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect I'm doing it wrong. There's no * next to the label text, when I preview the forms on my branch.

The next field How are you running Renovate? does show the * in the preview. 😜

@rarkins
Copy link
Collaborator

rarkins commented May 28, 2023

I agree with your comments in the main discussion. There's little chance this makes a difference to stubborn users who already click past our warnings

@rarkins rarkins closed this May 28, 2023
@HonkingGoose HonkingGoose deleted the chore/add-i-am-a-maintainer-checkbox-to-forms branch May 28, 2023 12:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants