-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding): skip processing onboarding branch #22490
feat(onboarding): skip processing onboarding branch #22490
Conversation
lib/workers/repository/onboarding/branch/onboarding-branch-cache.ts
Outdated
Show resolved
Hide resolved
Does this help (or make things more complicated) regarding the optimization I've proposed here? My use-case consists of tons of repos that do not contain a |
This PR won't affect your use case since this logic only comes in effect once we know that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
lib/workers/repository/onboarding/branch/onboarding-branch-cache.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Coverage problem in workers-1 shard |
maybe admin merge the lcov change and clear the codecov data |
Needs coverage |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 35.139.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
onboardingCacheValid
to theOnboardingState
class which is computed at the beginning and is used to determine if theonboardingCache
is validOnboardingBranchCache
:configFileName
andconfigFileParsed
onboardingCache
is valid we reuse this stored info to prevent cloning to find the renovate config file name and its contentElse onboarding branch is processed and the
configFileName
andconfigFileParsed
are cached to be used on next runContext
The GitHub app has something like 50k onboarding repos. So we need some optimizations to reduce the amount of time spent in processing them.
I think if we skip work if main/onboarding branch SHAs are untouched then it’s quick enough
Slack Message @rarkins
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: