Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release-notes)!: support configurable fetching stage #22781

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • convert fetchReleaseNotes to string type with allowedValues: off | branch | pr
  • add functionality to allow fetching release notes during branch update

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Show resolved Hide resolved
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review June 16, 2023 14:08
@RahulGautamSingh
Copy link
Collaborator Author

Migration test-repo: RahulGautamSingh-testing/migrate-22781#2

lib/config/types.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/index.ts Show resolved Hide resolved
lib/workers/repository/updates/branchify.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Jun 18, 2023
rarkins
rarkins previously approved these changes Jun 18, 2023
viceice
viceice previously approved these changes Jun 18, 2023
@rarkins rarkins added this pull request to the merge queue Jun 18, 2023
@rarkins rarkins removed this pull request from the merge queue due to a manual request Jun 18, 2023
@rarkins rarkins changed the title feat: increase fetchReleaseNotes capability feat(release-notes)!: support configurable fetching stage Jun 18, 2023
@rarkins rarkins changed the base branch from main to v36 June 18, 2023 08:11
@rarkins rarkins dismissed stale reviews from viceice and themself June 18, 2023 08:11

The base branch was changed.

@rarkins rarkins merged commit 6515df8 into renovatebot:v36 Jun 18, 2023
36 checks passed
rarkins pushed a commit that referenced this pull request Jun 18, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jun 18, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jun 27, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jun 27, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 1, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 4, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 4, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 4, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 4, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
rarkins pushed a commit that referenced this pull request Jul 4, 2023
Changes fetchReleaseNotes from boolean to enum, with values off, branch, pr.

Closes #20476

BREAKING CHANGE: Release notes won't be fetched early for commitBody insertion unless explicitly configured with fetchReleaseNotes=branch
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure when release notes are fetched, defaulting to latest/laziest
3 participants