fix(changelog): remove urls from md heading url #23112
Conversation
setchy
changed the title
setchy
added
type:bug
|
🎉 This PR is included in version 35.159.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
looks like this broke changelogs? ### [`v16.0.2`](https://github.com/primefaces/primeng/blob/HEAD/CHANGELOG.md#1602-2023-06-21)
[Compare Source](https://github.com/primefaces/primeng/compare/16.0.1...16.0.2)
[Full Changelog](https://github.com/primefaces/primeng/compare/16.0.1...16.0.2)
**Fixed bugs:**
- FileUploader: Choose button is missing icon spacing #​13232](https://github.com/primefaces/primeng/issues#​13232)
- Compiler error: p-autoComplete Argument of type 'Event' is not assignable to parameter of type 'MouseEvent' #​13227](https://github.com/primefaces/primeng/issues#​13227)
- p-dropdown unable to auto-select first item if group used #​12637](https://github.com/primefaces/primeng/issues#​12637)
- Component: Tooltip has no default zindex 16.0.1 #​13220](https://github.com/primefaces/primeng/issues#​13220)
- Clear filter Icon is not showing in p-columnfilter Component #​12947](https://github.com/primefaces/primeng/issues#​12947)
- Table Filter: Remove filter button is invisible #​13134](https://github.com/primefaces/primeng/issues#​13134)
- In table filter slash icon is not displaying when data is entered in the row filter. #​13222](https://github.com/primefaces/primeng/issues#​13222)
- Error: Cannot resolve type entity SafeHtmlPipe to symbol #​13218](https://github.com/primefaces/primeng/issues#​13218) |
| @@ -6,7 +6,7 @@ import { regEx } from './regex'; | |||
| export function sanitizeMarkdown(markdown: string): string { | |||
| let res = markdown; | |||
| // Put a zero width space after every # followed by a digit | |||
| res = res.replace(regEx(/#(\d)/gi), '#​$1'); | |||
| res = res.replace(regEx(/\W#(\d)/gi), '#​$1'); | |||
There was a problem hiding this comment.
this removes the char before the # 🤦♂️
There was a problem hiding this comment.
Do you have an example.... I can add this to the test-cases...
There was a problem hiding this comment.
I think this might be better
regex: (\W)#(\d)
replacement: $1#$2
There was a problem hiding this comment.
The other route I explored was using %23 instead of the # in release-notes.ts and then re-replacing it from %23 to # at the end of sanitizeMarkdown....
There was a problem hiding this comment.
I tried reproducing the "removes the char before #", but couldn't... 🤔
There was a problem hiding this comment.
I think this might be better
regex:
(\W)#(\d)
replacement: $1#$2
yes, otherwise the chat before will be removed, see screenshot and sample markdown on other PR comment
|
Adding missing test scenario #23160 |
Changes
Removes any urls when generating the markdown header url
Context
Current behavior generates markdown header urls for standard-version changelog files that include the github compare url
This PR ensures that this is omitted when generating the markdown header url link
Test Repository:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: