Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/helm): Skip helm charts with no listed versions #23223

Merged
merged 3 commits into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/modules/datasource/helm/__fixtures__/index_emptypackage.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
apiVersion: v1
entries:
viceice marked this conversation as resolved.
Show resolved Hide resolved
aerospike: []
ambassador:
- apiVersion: v1
appVersion: 0.70.1
created: 2019-06-02T08:56:36.119470813Z
description: A Helm chart for Datawire Ambassador
digest: 880002d74accfc9dab1debcc78c134fb4989e73ff84b137ce7aa92bf4d726297
engine: gotpl
home: https://www.getambassador.io/
icon: https://www.getambassador.io/images/logo.png
name: ambassador
sources:
- https://github.com/datawire/ambassador
- https://github.com/prometheus/statsd_exporter
urls:
- https://charts.helm.sh/stable/packages/ambassador-2.7.0.tgz
version: 2.7.0
18 changes: 18 additions & 0 deletions lib/modules/datasource/helm/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,24 @@ describe('modules/datasource/helm/index', () => {
expect(releases).toMatchSnapshot();
});

it('returns list of versions for other packages if one packages has no versions', async () => {
httpMock
.scope('https://example-repository.com')
.get('/index.yaml')
.reply(200, Fixtures.get('index_emptypackage.yaml'));
const releases = await getPkgReleases({
datasource: HelmDatasource.id,
packageName: 'ambassador',
registryUrls: ['https://example-repository.com'],
});
expect(releases).toMatchObject({
homepage: 'https://www.getambassador.io/',
registryUrl: 'https://example-repository.com',
sourceUrl: 'https://github.com/datawire/ambassador',
releases: expect.toBeArrayOfSize(1),
});
});

it('adds trailing slash to subdirectories', async () => {
httpMock
.scope('https://example-repository.com')
Expand Down
3 changes: 3 additions & 0 deletions lib/modules/datasource/helm/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ export class HelmDatasource extends Datasource {
}
const result: HelmRepositoryData = {};
for (const [name, releases] of Object.entries(doc.entries)) {
if (releases.length === 0) {
continue;
}
const latestRelease = releases[0];
const sourceUrl = findSourceUrl(latestRelease);
result[name] = {
Expand Down