fix(datasource/helm): Skip helm charts with no listed versions

lib/modules/datasource/helm/__fixtures__/index_emptypackage.yaml

@@ -0,0 +1,91 @@
+apiVersion: v1
+entries:
+  acs-engine-autoscaler:
+  - apiVersion: v1
+    appVersion: 2.1.1
+    created: 2019-06-02T08:56:36.116031089Z
+    deprecated: true
+    description: DEPRECATED Scales worker nodes within agent pools
+    digest: 93f924d4498d588bcdda88c7401e27c6fa0f50ff0601e78885eca13eb683c1e2
+    home: https://github.com/wbuchwalter/Kubernetes-acs-engine-autoscaler
+    icon: https://github.com/kubernetes/kubernetes/blob/master/logo/logo.png
+    name: acs-engine-autoscaler
+    sources:
+    - https://github.com/wbuchwalter/Kubernetes-acs-engine-autoscaler
+    urls:
+    - https://charts.helm.sh/stable/packages/acs-engine-autoscaler-2.2.2.tgz
+    version: 2.2.2
+  - apiVersion: v1
+    appVersion: 2.1.1
+    created: 2018-12-11T02:55:17.96986758Z
+    description: Scales worker nodes within agent pools
+    digest: 3232999ebabc42cd7c5475251b5cd2e0c6bf4363551cff13ebe3a78cee1dfba6
+    home: https://github.com/wbuchwalter/Kubernetes-acs-engine-autoscaler
+    icon: https://github.com/kubernetes/kubernetes/blob/master/logo/logo.png
+    maintainers:
+    - email: ritazh@microsoft.com
+      name: ritazh
+    - email: wibuch@microsoft.com
+      name: wbuchwalter
+    name: acs-engine-autoscaler
+    sources:
+    - https://github.com/wbuchwalter/Kubernetes-acs-engine-autoscaler
+    urls:
+    - https://charts.helm.sh/stable/packages/acs-engine-autoscaler-2.2.1.tgz
+    version: 2.2.1
+  aerospike: []
+  ambassador:
+  - apiVersion: v1
+    appVersion: 0.70.1
+    created: 2019-06-02T08:56:36.119470813Z
+    description: A Helm chart for Datawire Ambassador
+    digest: 880002d74accfc9dab1debcc78c134fb4989e73ff84b137ce7aa92bf4d726297
+    engine: gotpl
+    home: https://www.getambassador.io/
+    icon: https://www.getambassador.io/images/logo.png
+    keywords:
+    - api gateway
+    - ambassador
+    - datawire
+    - envoy
+    maintainers:
+    - email: markus@maga.se
+      name: flydiverny
+    - email: flynn@datawire.io
+      name: kflynn
+    - email: nkrause@datawire.io
+      name: nbkrause
+    name: ambassador
+    sources:
+    - https://github.com/datawire/ambassador
+    - https://github.com/prometheus/statsd_exporter
+    urls:
+    - https://charts.helm.sh/stable/packages/ambassador-2.7.0.tgz
+    version: 2.7.0
+  - apiVersion: v1
+    appVersion: 0.70.1
+    created: 2019-05-31T18:57:01.540843138Z
+    description: A Helm chart for Datawire Ambassador
+    digest: ba549d35ca7827573343fe1613dcad31f258bfcc2959f6005220bfb300030a21
+    engine: gotpl
+    home: https://www.getambassador.io/
+    icon: https://www.getambassador.io/images/logo.png
+    keywords:
+    - api gateway
+    - ambassador
+    - datawire
+    - envoy
+    maintainers:
+    - email: markus@maga.se
+      name: flydiverny
+    - email: flynn@datawire.io
+      name: kflynn
+    - email: nkrause@datawire.io
+      name: nbkrause
+    name: ambassador
+    sources:
+    - https://github.com/datawire/ambassador
+    - https://github.com/prometheus/statsd_exporter
+    urls:
+    - https://charts.helm.sh/stable/packages/ambassador-2.6.2.tgz
+    version: 2.6.2

lib/modules/datasource/helm/__snapshots__/index.spec.ts.snap

@@ -116,3 +116,21 @@ exports[`modules/datasource/helm/index getReleases returns list of versions for
   "sourceUrl": "https://github.com/datawire/ambassador",
 }
 `;
+
+exports[`modules/datasource/helm/index getReleases returns list of versions for other packages if one packages has no versions 1`] = `
+{
+  "homepage": "https://www.getambassador.io/",
+  "registryUrl": "https://example-repository.com",
+  "releases": [
+    {
+      "releaseTimestamp": "2019-05-31T18:57:01.540Z",
+      "version": "2.6.2",
+    },
+    {
+      "releaseTimestamp": "2019-06-02T08:56:36.119Z",
+      "version": "2.7.0",
+    },
+  ],
+  "sourceUrl": "https://github.com/datawire/ambassador",
+}
+`;

lib/modules/datasource/helm/index.spec.ts

@@ -6,6 +6,7 @@ import { HelmDatasource } from '.';
 
 // Truncated index.yaml file
 const indexYaml = Fixtures.get('index.yaml');
+const emptyPackageIndexYaml = Fixtures.get('index_emptypackage.yaml');
 
 describe('modules/datasource/helm/index', () => {
   describe('getReleases', () => {
@@ -167,6 +168,20 @@ describe('modules/datasource/helm/index', () => {
       expect(releases).toMatchSnapshot();
     });
 
+    it('returns list of versions for other packages if one packages has no versions', async () => {
+      httpMock
+        .scope('https://example-repository.com')
+        .get('/index.yaml')
+        .reply(200, emptyPackageIndexYaml);
+      const releases = await getPkgReleases({
+        datasource: HelmDatasource.id,
+        packageName: 'ambassador',
+        registryUrls: ['https://example-repository.com'],
+      });
+      expect(releases).not.toBeNull();
+      expect(releases).toMatchSnapshot();
+    });
+
     it('adds trailing slash to subdirectories', async () => {
       httpMock
         .scope('https://example-repository.com')

lib/modules/datasource/helm/index.ts

@@ -60,6 +60,9 @@ export class HelmDatasource extends Datasource {
       }
       const result: HelmRepositoryData = {};
       for (const [name, releases] of Object.entries(doc.entries)) {
+        if (releases.length === 0) {
+          continue;
+        }
         const latestRelease = releases[0];
         const sourceUrl = findSourceUrl(latestRelease);
         result[name] = {