Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Better tests for Result class #23473

Merged
merged 4 commits into from
Jul 20, 2023
Merged

refactor: Better tests for Result class #23473

merged 4 commits into from
Jul 20, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 20, 2023 •
edited

Changes

Also adds proper handling for uncaught async transform error

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice July 20, 2023 09:19
@viceice viceice changed the title refactor: Better tests for Result class test: Better tests for Result class Jul 20, 2023
@viceice viceice changed the title test: Better tests for Result class refactor: Better tests for Result class Jul 20, 2023
viceice
viceice reviewed Jul 20, 2023
View reviewed changes
lib/util/result.ts Show resolved Hide resolved
lib/util/result.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 20, 2023 09:45
@viceice viceice added this pull request to the merge queue Jul 20, 2023
Merged via the queue into renovatebot:main with commit 58f7c03 Jul 20, 2023
34 checks passed
@viceice viceice deleted the refactor/result-tests branch July 20, 2023 16:15
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zharinov @renovate-release @viceice